Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-auth charter (v2) #2431

Merged
merged 3 commits into from
Jul 30, 2018
Merged

Conversation

tallclair
Copy link
Member

Add a sig-auth charter, based on the sig-charter-template.

The first attempt at our charter is in #2000.

Co-authored by: @liggitt @mikedanese @tallclair

/sig auth

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2018
SIG Auth is responsible for the design, implementation, and maintenance of features in
Kubernetes that control and protect access to the API and other core components. This includes
authentication and authorization, but also encompasses features like auditing and some policy
(see below).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt @mikedanese - This is the only piece that isn't copied from the scope we discussed. PTAL

@tallclair
Copy link
Member Author

/assign @liggitt
/assign @mikedanese

@cblecker
Copy link
Member

/committee steering
/cc @kubernetes/steering-committee

@k8s-ci-robot k8s-ci-robot requested a review from a team July 28, 2018 05:21
@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Jul 28, 2018
Copy link
Contributor

@jbeda jbeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Appropriately scoped and on topic with what the SIG has traditionally been doing. One nitpick and a call out to define subprojects (perhaps in differnt PR)


#### Code, Binaries and Services

- Kubernetes authentication, authorization, audit and policy features. Examples include:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/policy/security policy/? How does this overlap with other policy aspects? Or do you think that it doesn't?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. We actually were going to change that to security policy, but I guess that change got lost.

I agree this is a fuzzy area, and the policy scope of sig-auth isn't super well defined. I think that is partly because most policy features are cross-cutting. For example, PodSecruityPolicy should really be co-owned by sig-auth & sig-node. SchedulingPolicy should be sig-auth & sig-scheduling. Network policy is probably just sig-networking, since it's only a runtime policy (comparable to PodSecurityContext).

I see our (sig-auth) role around policy as:

  • helping to drive consistency across policies (really co-owned with wg-policy)
  • owning the policy primitives & mechanisms (co-owned with api-machinery)
  • ensuring that important use cases are covered by the existing authorization & policy mechanisms

Does this make sense? I can try to distill this into our scope if we all agree.

This sig follows adheres to the Roles and Organization Management outlined in [sig-governance]
and opts-in to updates and modifications to [sig-governance].

### Subproject Creation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done in a different PR, but there are no subprojects defined for SIG-auth defined in sigs.yaml. How are y'all thinking about breaking this down into smaller chunks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enumerating those is in progress in https://docs.google.com/document/d/1RJvnSPOJ3JC61gerCpCpaCtzQjRcsZ2tXkcyokr6sLY

A follow up to this PR would transfer those into sigs.yaml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #2505

@tallclair tallclair force-pushed the sig-auth-charter-v2 branch from 6a829d5 to 41a8955 Compare July 30, 2018 18:39
Copy link

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. thank you!

@michelleN
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2018
@michelleN
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelleN

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8bbdc33 into kubernetes:master Jul 30, 2018
@philips
Copy link
Contributor

philips commented Jul 30, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants